Skip to content

Update ServerConfiguration to use ConfigKey and ConfigKeyGroup#1893

Open
sijie wants to merge 7 commits intoapache:masterfrom
sijie:more_config_keys
Open

Update ServerConfiguration to use ConfigKey and ConfigKeyGroup#1893
sijie wants to merge 7 commits intoapache:masterfrom
sijie:more_config_keys

Conversation

@sijie
Copy link
Member

@sijie sijie commented Dec 29, 2018

Descriptions of the changes in this PR:

Motivation

This PR is part of BP-37 - using the new configuration framework to re-organize server configuration

Changes

Update server configuration to use ConfigKey and ConfigKeyGroup

Master Issue: #1867

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@sijie
Update ServerConfiguration to use ConfigKey and ConfigKeyGroup
dcd2b09 
*Motivation*

This PR is part of BP-37 - using the new configuration framework to re-organize server configuration

*Changes*

Update server configuration to use ConfigKey and ConfigKeyGroup

Master Issue: apache#1867
@sijie sijie added this to the 4.9.0 milestone Dec 29, 2018
@sijie sijie self-assigned this Dec 29, 2018
eolivelli
eolivelli approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java Outdated
protected static final String METADATA_SERVICE_URI = "metadataServiceUri";
protected static final ConfigKey METADATA_SERVICE_URI_KEY = ConfigKey.builder(METADATA_SERVICE_URI)
.type(Type.STRING)
.description("metadata service uri that bookkeeper is used for loading corresponding metadata driver"
Copy link
Contributor

@eolivelli eolivelli Dec 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 'is used' -> 'uses'

@sijie
Copy link
Member Author

sijie commented Jan 14, 2019

run integration tests

@sijie sijie modified the milestones: 4.9.0, 4.10.0 Jan 15, 2019
@eolivelli
Copy link
Contributor

eolivelli commented Jan 17, 2019

retest this please

@eolivelli
Copy link
Contributor

eolivelli commented Jul 27, 2019

@sijie it is worth to rebase this patch and ship it for 4.10, do you have cycles ?

@jiazhai
Copy link
Member

jiazhai commented Oct 29, 2019

would like to put it into 4.11

@jiazhai jiazhai modified the milestones: 4.10.0, 4.11.0 Oct 29, 2019
@Ghatage
Copy link
Contributor

Ghatage commented Jun 10, 2020

run integration tests

@eolivelli
Copy link
Contributor

eolivelli commented Jun 11, 2020

@sijie can you please rebase ? if you want this to be part of 4.11 release

@rdhabalia rdhabalia modified the milestones: 4.11.0, 4.12.0 Jun 18, 2020
@eolivelli eolivelli modified the milestones: 4.12.0, 4.13.0 Nov 4, 2020
@dlg99 dlg99 removed this from the 4.13.0 milestone Feb 16, 2021
@dlg99 dlg99 added this to the 4.14.0 milestone Feb 16, 2021
@dlg99 dlg99 modified the milestones: 4.14.0, 4.15.0 May 7, 2021
@dlg99 dlg99 modified the milestones: 4.15.0, 4.16.0 Mar 11, 2022
@hangc0276 hangc0276 modified the milestones: 4.16.0, 4.17.0 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiazhai jiazhai jiazhai approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

@sijie sijie

Labels

area/config type/task

Projects

None yet

Milestone

4.17.0

Development

Successfully merging this pull request may close these issues.

7 participants

@sijie @eolivelli @jiazhai @Ghatage @rdhabalia @hangc0276 @dlg99